Commit b0229605 authored by Julien Massot's avatar Julien Massot Committed by Mathieu Poirier
Browse files

remoteproc: rcar_rproc: Fix pm_runtime_get_sync error check 



pm_runtime_get_sync can also return 1 on success, change
to use pm_runtime_resume_and_get which return 0 only on
success.

This bug has been discovered by Dan Carpenter by using Smatch
static checker.

Fixes: 285892a7 ("remoteproc: Add Renesas rcar driver")
Signed-off-by: default avatarJulien Massot <julien.massot@iot.bzh>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
[Fixed blank line between tags]
Link: https://lore.kernel.org/r/20211216160653.203768-1-julien.massot@iot.bzh


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 3bc0d1f9

drivers/remoteproc/rcar_rproc.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int rcar_rproc_probe(struct platform_device *pdev) 
	}



	pm_runtime_enable(dev);

	ret = pm_runtime_get_sync(dev);

	ret = pm_runtime_resume_and_get(dev);

	if (ret) {

		dev_err(dev, "failed to power up\n");

		return ret;