Commit afef1e1a authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_kunit_util: add default value for `msg->result` 



Add default value for `msg->result` so that it won't be garbage bytes
when the mock list is empty.

Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20220720044754.4026295-3-tzungbi@kernel.org
parent f92dd147

drivers/platform/chrome/cros_kunit_util.c

+5 −1
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
#include "cros_ec.h"

#include "cros_kunit_util.h"



int cros_kunit_ec_xfer_mock_default_result;

int cros_kunit_ec_xfer_mock_default_ret;

int cros_kunit_ec_cmd_xfer_mock_called;

int cros_kunit_ec_pkt_xfer_mock_called;
@@ -25,8 +26,10 @@ int cros_kunit_ec_xfer_mock(struct cros_ec_device *ec_dev, struct cros_ec_comman 
	struct ec_xfer_mock *mock;



	mock = list_first_entry_or_null(&cros_kunit_ec_xfer_mock_in, struct ec_xfer_mock, list);

	if (!mock)

	if (!mock) {

		msg->result = cros_kunit_ec_xfer_mock_default_result;

		return cros_kunit_ec_xfer_mock_default_ret;

	}



	list_del(&mock->list);
@@ -112,6 +115,7 @@ int cros_kunit_readmem_mock(struct cros_ec_device *ec_dev, unsigned int offset, 


void cros_kunit_mock_reset(void)

{

	cros_kunit_ec_xfer_mock_default_result = 0;

	cros_kunit_ec_xfer_mock_default_ret = 0;

	cros_kunit_ec_cmd_xfer_mock_called = 0;

	cros_kunit_ec_pkt_xfer_mock_called = 0;

drivers/platform/chrome/cros_kunit_util.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ struct ec_xfer_mock { 
	u32 o_data_len;

};



extern int cros_kunit_ec_xfer_mock_default_result;

extern int cros_kunit_ec_xfer_mock_default_ret;

extern int cros_kunit_ec_cmd_xfer_mock_called;

extern int cros_kunit_ec_pkt_xfer_mock_called;