Commit afb349c0 authored by Zhen Lei's avatar Zhen Lei Committed by Lee Jones
Browse files

mfd: ab8500-core: Use DEVICE_ATTR_RO/RW macro 



Use DEVICE_ATTR_RO/RW macro helper instead of plain DEVICE_ATTR, which
makes the code a bit shorter and easier to read.

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 5089e34f

drivers/mfd/ab8500-core.c

+16 −17
Original line number Diff line number Diff line
@@ -827,7 +827,7 @@ static const struct mfd_cell ab8540_cut2_devs[] = { 
	},

};



static ssize_t show_chip_id(struct device *dev,

static ssize_t chip_id_show(struct device *dev,

			    struct device_attribute *attr, char *buf)

{

	struct ab8500 *ab8500;
@@ -848,7 +848,7 @@ static ssize_t show_chip_id(struct device *dev, 
 * 0x40 Power on key 1 pressed longer than 10 seconds

 * 0x80 DB8500 thermal shutdown

 */

static ssize_t show_switch_off_status(struct device *dev,

static ssize_t switch_off_status_show(struct device *dev,

				      struct device_attribute *attr, char *buf)

{

	int ret;
@@ -883,7 +883,7 @@ void ab8500_override_turn_on_stat(u8 mask, u8 set) 
 * 0x40 UsbIDDetect

 * 0x80 Reserved

 */

static ssize_t show_turn_on_status(struct device *dev,

static ssize_t turn_on_status_show(struct device *dev,

				   struct device_attribute *attr, char *buf)

{

	int ret;
@@ -912,7 +912,7 @@ static ssize_t show_turn_on_status(struct device *dev, 
	return sprintf(buf, "%#x\n", value);

}



static ssize_t show_turn_on_status_2(struct device *dev,

static ssize_t turn_on_status_2_show(struct device *dev,

				     struct device_attribute *attr, char *buf)

{

	int ret;
@@ -927,7 +927,7 @@ static ssize_t show_turn_on_status_2(struct device *dev, 
	return sprintf(buf, "%#x\n", (value & 0x1));

}



static ssize_t show_ab9540_dbbrstn(struct device *dev,

static ssize_t dbbrstn_show(struct device *dev,

			    struct device_attribute *attr, char *buf)

{

	struct ab8500 *ab8500;
@@ -945,7 +945,7 @@ static ssize_t show_ab9540_dbbrstn(struct device *dev, 
			(value & AB9540_MODEM_CTRL2_SWDBBRSTN_BIT) ? 1 : 0);

}



static ssize_t store_ab9540_dbbrstn(struct device *dev,

static ssize_t dbbrstn_store(struct device *dev,

	struct device_attribute *attr, const char *buf, size_t count)

{

	struct ab8500 *ab8500;
@@ -980,12 +980,11 @@ static ssize_t store_ab9540_dbbrstn(struct device *dev, 
	return ret;

}



static DEVICE_ATTR(chip_id, S_IRUGO, show_chip_id, NULL);

static DEVICE_ATTR(switch_off_status, S_IRUGO, show_switch_off_status, NULL);

static DEVICE_ATTR(turn_on_status, S_IRUGO, show_turn_on_status, NULL);

static DEVICE_ATTR(turn_on_status_2, S_IRUGO, show_turn_on_status_2, NULL);

static DEVICE_ATTR(dbbrstn, S_IRUGO | S_IWUSR,

			show_ab9540_dbbrstn, store_ab9540_dbbrstn);

static DEVICE_ATTR_RO(chip_id);

static DEVICE_ATTR_RO(switch_off_status);

static DEVICE_ATTR_RO(turn_on_status);

static DEVICE_ATTR_RO(turn_on_status_2);

static DEVICE_ATTR_RW(dbbrstn);



static struct attribute *ab8500_sysfs_entries[] = {

	&dev_attr_chip_id.attr,