Commit afaed2b1 authored by Tobias Waldekranz's avatar Tobias Waldekranz Committed by Jakub Kicinski
Browse files

net: dsa: mv88e6xxx: Require ops be implemented to claim STU support 



Simply having a physical STU table in the device doesn't do us any
good if there's no implementation of the relevant ops to access that
table. So ensure that chips that claim STU support can also talk to
the hardware.

This fixes an issue where chips that had a their ->info->max_sid
set (due to their family membership), but no implementation (due to
their chip-specific ops struct) would fail to probe.

Fixes: 49c98c1d ("net: dsa: mv88e6xxx: Disentangle STU from VTU")
Reported-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarTobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Tested-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e0c0ca35

drivers/net/dsa/mv88e6xxx/chip.h

+3 −1
Original line number Diff line number Diff line
@@ -730,7 +730,9 @@ struct mv88e6xxx_hw_stat { 


static inline bool mv88e6xxx_has_stu(struct mv88e6xxx_chip *chip)

{

	return chip->info->max_sid > 0;

	return chip->info->max_sid > 0 &&

		chip->info->ops->stu_loadpurge &&

		chip->info->ops->stu_getnext;

}



static inline bool mv88e6xxx_has_pvt(struct mv88e6xxx_chip *chip)