Commit afae6254 authored by Gal Pressman's avatar Gal Pressman Committed by Saeed Mahameed
Browse files

net/mlx5e: Remove incorrect debugfs_create_dir NULL check in hairpin 



Remove the NULL check on debugfs_create_dir() return value as the
function returns an ERR pointer on failure, not NULL.
The check is not replaced with a IS_ERR_OR_NULL() as
debugfs_create_file(), and debugfs functions in general don't need error
checking.

Fixes: 0e414518 ("net/mlx5e: Add hairpin debugfs files")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 2e762e65

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+0 −2
Original line number Diff line number Diff line
@@ -1124,8 +1124,6 @@ static void mlx5e_tc_debugfs_init(struct mlx5e_tc_table *tc, 
		return;



	tc->dfs_root = debugfs_create_dir("tc", dfs_root);

	if (!tc->dfs_root)

		return;



	debugfs_create_file("hairpin_num_queues", 0644, tc->dfs_root,

			    &tc->hairpin_params, &fops_hairpin_queues);