Commit afa37315 authored by Luben Tuikov's avatar Luben Tuikov Committed by Alex Deucher
Browse files

drm/amdgpu: Print once if RAS unsupported 



MESA polls for errors every 2-3 seconds. Printing with dev_info() causes
the dmesg log to fill up with the same message, e.g,

[18028.206676] amdgpu 0000:0b:00.0: amdgpu: df doesn't config ras function.

Make it dev_dbg_once(), as it isn't something correctible during boot or
thereafter, so printing just once is sufficient. Also sanitize the message.

Cc: Alex Deucher <Alexander.Deucher@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: John Clements <john.clements@amd.com>
Cc: Tao Zhou <tao.zhou1@amd.com>
Cc: yipechai <YiPeng.Chai@amd.com>
Fixes: 8b0fb0e9 ("drm/amdgpu: Modify gfx block to fit for the unified ras block data and ops")
Signed-off-by: default avatarLuben Tuikov <luben.tuikov@amd.com>
Reviewed-by: default avatarAlex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e56694f7

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+8 −8
Original line number Diff line number Diff line
@@ -952,7 +952,7 @@ int amdgpu_ras_query_error_status(struct amdgpu_device *adev, 
	} else {

		block_obj = amdgpu_ras_get_ras_block(adev, info->head.block, 0);

		if (!block_obj || !block_obj->hw_ops)   {

			dev_info(adev->dev, "%s doesn't config ras function.\n",

			dev_dbg_once(adev->dev, "%s doesn't config RAS function\n",

				     get_ras_block_str(&info->head));

			return -EINVAL;

		}
@@ -1028,7 +1028,7 @@ int amdgpu_ras_reset_error_status(struct amdgpu_device *adev, 
		return -EINVAL;



	if (!block_obj || !block_obj->hw_ops)   {

		dev_info(adev->dev, "%s doesn't config ras function.\n",

		dev_dbg_once(adev->dev, "%s doesn't config RAS function\n",

			     ras_block_str(block));

		return -EINVAL;

	}
@@ -1066,7 +1066,7 @@ int amdgpu_ras_error_inject(struct amdgpu_device *adev, 
		return -EINVAL;



	if (!block_obj || !block_obj->hw_ops)	{

		dev_info(adev->dev, "%s doesn't config ras function.\n",

		dev_dbg_once(adev->dev, "%s doesn't config RAS function\n",

			     get_ras_block_str(&info->head));

		return -EINVAL;

	}
@@ -1717,7 +1717,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev, 
					info->head.sub_block_index);



	if (!block_obj || !block_obj->hw_ops) {

		dev_info(adev->dev, "%s doesn't config ras function.\n",

		dev_dbg_once(adev->dev, "%s doesn't config RAS function\n",

			     get_ras_block_str(&info->head));

		return;

	}