Commit af7e82bd authored by Markus Elfring's avatar Markus Elfring Committed by ZhangPeng
Browse files

auxdisplay: ht16k33: Drop reference after LED registration 

stable inclusion
from stable-v6.6.44
commit 64dc362dee40392b248de4a5fd095a3f3eb2f142
bugzilla: https://gitee.com/openeuler/kernel/issues/IAHMJO

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=64dc362dee40392b248de4a5fd095a3f3eb2f142



--------------------------------

[ Upstream commit 2ccfe94bc3ac980d2d1df9f7a0b2c6d2137abe55 ]

The reference count is bumped by device_get_named_child_node()
and never dropped. Since LED APIs do not require it to be
bumped by the user, drop the reference after LED registration.

[andy: rewritten the commit message and amended the change]

Fixes: c223d9c6 ("auxdisplay: ht16k33: Add LED support")
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
parent 31829d5e

drivers/auxdisplay/ht16k33.c

+1 −0
Original line number Diff line number Diff line
@@ -507,6 +507,7 @@ static int ht16k33_led_probe(struct device *dev, struct led_classdev *led, 
	led->max_brightness = MAX_BRIGHTNESS;



	err = devm_led_classdev_register_ext(dev, led, &init_data);

	fwnode_handle_put(init_data.fwnode);

	if (err)

		dev_err(dev, "Failed to register LED\n");