Commit af7d23f9 authored by Yang Yingliang's avatar Yang Yingliang Committed by David S. Miller
Browse files

octeontx2-pf: mcs: fix possible memory leak in otx2_probe() 



In error path after calling cn10k_mcs_init(), cn10k_mcs_free() need
be called to avoid memory leak.

Fixes: c54ffc73 ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84cdf5bc

drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

+3 −1
Original line number Diff line number Diff line
@@ -2810,7 +2810,7 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	err = register_netdev(netdev);

	if (err) {

		dev_err(dev, "Failed to register netdevice\n");

		goto err_del_mcam_entries;

		goto err_mcs_free;

	}



	err = otx2_wq_init(pf);
@@ -2849,6 +2849,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	otx2_mcam_flow_del(pf);

err_unreg_netdev:

	unregister_netdev(netdev);

err_mcs_free:

	cn10k_mcs_free(pf);

err_del_mcam_entries:

	otx2_mcam_flow_del(pf);

err_ptp_destroy: