Commit af505cad authored by Nirmoy Das's avatar Nirmoy Das Committed by Greg Kroah-Hartman
Browse files

debugfs: debugfs_create_file_size(): use IS_ERR to check for error 



debugfs_create_file() returns encoded error so use IS_ERR for checking
return value.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarNirmoy Das <nirmoy.das@amd.com>
Fixes: ff9fb72b ("debugfs: return error values, not NULL")
Cc: stable <stable@vger.kernel.org>
References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6880fa6c

fs/debugfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode, 
{

	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);



	if (de)

	if (!IS_ERR(de))

		d_inode(de)->i_size = file_size;

}

EXPORT_SYMBOL_GPL(debugfs_create_file_size);