Commit af21250b authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Christoph Hellwig
Browse files

nvmet-tcp: fix memory leak when performing a controller reset 



If a reset controller is executed while the initiator
is performing some I/O the driver may leak the memory allocated
for the commands' iovec.

Make sure that nvmet_tcp_uninit_data_in_cmds() releases
all the memory.

Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarJohn Meneghini <jmeneghi@redhat.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 69b85e1f

drivers/nvme/target/tcp.c

+4 −1
Original line number Diff line number Diff line
@@ -1427,7 +1427,10 @@ static void nvmet_tcp_uninit_data_in_cmds(struct nvmet_tcp_queue *queue) 


	for (i = 0; i < queue->nr_cmds; i++, cmd++) {

		if (nvmet_tcp_need_data_in(cmd))

			nvmet_tcp_finish_cmd(cmd);

			nvmet_req_uninit(&cmd->req);



		nvmet_tcp_unmap_pdu_iovec(cmd);

		nvmet_tcp_free_cmd_buffers(cmd);

	}



	if (!queue->nr_cmds && nvmet_tcp_need_data_in(&queue->connect)) {