Commit af1db8f1 authored Jul 15, 2020 by Darrick J. Wong

xfs: remove unnecessary quota type masking



When XFS' quota functions take a parameter for the quota type, they only
care about the three quota record types (user, group, project).
Internal state flags and whatnot should never be passed by callers and
are an error.  Now that we've moved responsibility for filtering out
internal state to the callers, we can drop the masking everywhere else.

In other words, if you call a quota function, you must only pass in
one of XFS_DQTYPE_{USER,GROUP,PROJ}.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 0b04dd5d

fs/xfs/xfs_dquot.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -136,7 +136,7 @@ xfs_dquot_type(const struct xfs_dquot *dqp)

		static inline int xfs_this_quota_on(struct xfs_mount *mp, int type)
		{
		switch (type & XFS_DQTYPE_REC_MASK) {
		switch (type) {
		case XFS_DQTYPE_USER:
		return XFS_IS_UQUOTA_ON(mp);
		case XFS_DQTYPE_GROUP:
		@@ -150,7 +150,7 @@ static inline int xfs_this_quota_on(struct xfs_mount *mp, int type)

		static inline struct xfs_dquot xfs_inode_dquot(struct xfs_inode ip, int type)
		{
		switch (type & XFS_DQTYPE_REC_MASK) {
		switch (type) {
		case XFS_DQTYPE_USER:
		return ip->i_udquot;
		case XFS_DQTYPE_GROUP:

fs/xfs/xfs_qm.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -88,7 +88,7 @@ xfs_dquot_tree(
		static inline struct xfs_inode *
		xfs_quota_inode(xfs_mount_t *mp, uint dq_flags)
		{
		switch (dq_flags & XFS_DQTYPE_REC_MASK) {
		switch (dq_flags) {
		case XFS_DQTYPE_USER:
		return mp->m_quotainfo->qi_uquotaip;
		case XFS_DQTYPE_GROUP: