Commit aef37cf3 authored Mar 29, 2025 by Thinh Nguyen Committed by Xiongfeng Wang Mar 29, 2025

usb: gadget: f_tcm: Don't free command immediately

stable inclusion
from stable-v5.10.235
commit 38229c35a6d7875697dfb293356407330cfcd23e
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBREC7
CVE: CVE-2025-21816

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=38229c35a6d7875697dfb293356407330cfcd23e



--------------------------------

commit c225d006a31949d673e646d585d9569bc28feeb9 upstream.

Don't prematurely free the command. Wait for the status completion of
the sense status. It can be freed then. Otherwise we will double-free
the command.

Fixes: cff834c1 ("usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs")
Cc: stable@vger.kernel.org
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/ae919ac431f16275e05ec819bdffb3ac5f44cbe1.1733876548.git.Thinh.Nguyen@synopsys.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>

parent e138c473

drivers/usb/gadget/function/f_tcm.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1068,7 +1068,6 @@ static void usbg_cmd_work(struct work_struct *work)
		out:
		transport_send_check_condition_and_sense(se_cmd,
		TCM_UNSUPPORTED_SCSI_OPCODE, 1);
		transport_generic_free_cmd(&cmd->se_cmd, 0);
		}

		static struct usbg_cmd usbg_get_cmd(struct f_uas fu,
		@@ -1199,7 +1198,6 @@ static void bot_cmd_work(struct work_struct *work)
		out:
		transport_send_check_condition_and_sense(se_cmd,
		TCM_UNSUPPORTED_SCSI_OPCODE, 1);
		transport_generic_free_cmd(&cmd->se_cmd, 0);
		}

		static int bot_submit_command(struct f_uas *fu,