Commit aef0f8c6 authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5: Fix format-security build warnings 



Treat the string as an argument to avoid this.

drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:482:5:
error: format string is not a string literal (potentially insecure)
                         name);
                         ^~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:2079:4:
error: format string is not a string literal (potentially insecure)
                        ptp_ch_stats_desc[i].format);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Reviewed-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
parent bc541621

drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

+1 −1
Original line number Diff line number Diff line
@@ -2076,7 +2076,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STRS(ptp) 


	for (i = 0; i < NUM_PTP_CH_STATS; i++)

		sprintf(data + (idx++) * ETH_GSTRING_LEN,

			ptp_ch_stats_desc[i].format);

			"%s", ptp_ch_stats_desc[i].format);



	if (priv->tx_ptp_opened) {

		for (tc = 0; tc < priv->max_opened_tc; tc++)

drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c

+1 −1
Original line number Diff line number Diff line
@@ -479,7 +479,7 @@ irq_pool_alloc(struct mlx5_core_dev *dev, int start, int size, char *name, 
	pool->xa_num_irqs.max = start + size - 1;

	if (name)

		snprintf(pool->name, MLX5_MAX_IRQ_NAME - MLX5_MAX_IRQ_IDX_CHARS,

			 name);

			 "%s", name);

	pool->min_threshold = min_threshold * MLX5_EQ_REFS_PER_IRQ;

	pool->max_threshold = max_threshold * MLX5_EQ_REFS_PER_IRQ;

	mlx5_core_dbg(dev, "pool->name = %s, pool->size = %d, pool->start = %d",