Commit aec22127 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: ov2722: Fix GPIO1 polarity 



The comment claims the PWDN pin is active when pulled down in other words,
it is /power-down so it needs to be driven high to get the sensor
powered-up (not powered down) and flag is 1 when powering-up the sensor
so the ! is wrong, drop it.

This also matches with the schematics which I have which shows GPIO1 also
enables a 3.3v line to the sensor-module which controls the privacy-LED
and indeed before this patch the privacy LED was inverted from what it
should be (and the sensor did not work).

Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 3ddac68f

drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

+1 −4
Original line number Diff line number Diff line
@@ -512,10 +512,7 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	 * before PWDN# when turning it on or off.

	 */

	ret = dev->platform_data->gpio0_ctrl(sd, flag);

	/*

	 *ov2722 PWDN# active high when pull down,opposite to the convention

	 */

	ret |= dev->platform_data->gpio1_ctrl(sd, !flag);

	ret |= dev->platform_data->gpio1_ctrl(sd, flag);

	return ret;

}