Commit ae9d475a authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson
Browse files

dt-bindings: remoteproc: qcom,glink-edge: define re-usable schema for glink-edge 



'glink-edge' property appears in multiple bindings, so split it into one
place which can be re-used.  This reduces code duplication and adds
strict schema matching for glink-edge nodes (instead of just
"type:object").

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220517070113.18023-8-krzysztof.kozlowski@linaro.org
parent c47b3b39

Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml

+1 −1
Original line number Diff line number Diff line
@@ -154,7 +154,7 @@ properties: 
      channels and devices related to the ADSP.



  glink-edge:

    type: object

    $ref: /schemas/remoteproc/qcom,glink-edge.yaml#

    description:

      Qualcomm G-Link subnode which represents communication edge, channels

      and devices related to the ADSP.

Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml

0 → 100644
+72 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/remoteproc/qcom,glink-edge.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Qualcomm G-Link Edge communication channel nodes



maintainers:

  - Bjorn Andersson <bjorn.andersson@linaro.org>



description:

  Qualcomm G-Link subnode represents communication edge, channels and devices

  related to the remote processor.



properties:

  $nodename:

    const: "glink-edge"



  apr:

    $ref: /schemas/soc/qcom/qcom,apr.yaml#

    description:

      Qualcomm APR/GPR (Asynchronous/Generic Packet Router)



  fastrpc:

    type: object

    description:

      See Documentation/devicetree/bindings/misc/qcom,fastrpc.txt



  interrupts:

    maxItems: 1



  label:

    description: The names of the state bits used for SMP2P output



  mboxes:

    maxItems: 1



  qcom,remote-pid:

    $ref: /schemas/types.yaml#/definitions/uint32

    description:

      ID of the shared memory used by GLINK for communication with remote

      processor.



required:

  - interrupts

  - label

  - mboxes

  - qcom,remote-pid



additionalProperties: false



examples:

  - |

    #include <dt-bindings/interrupt-controller/arm-gic.h>

    #include <dt-bindings/mailbox/qcom-ipcc.h>



    remoteproc@8a00000 {

        reg = <0x08a00000 0x10000>;

        // ...



        glink-edge {

            interrupts-extended = <&ipcc IPCC_CLIENT_WPSS

                                         IPCC_MPROC_SIGNAL_GLINK_QMP

                                         IRQ_TYPE_EDGE_RISING>;

            mboxes = <&ipcc IPCC_CLIENT_WPSS

                            IPCC_MPROC_SIGNAL_GLINK_QMP>;



            label = "wpss";

            qcom,remote-pid = <13>;

        };

    };

Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml

+4 −14
Original line number Diff line number Diff line
@@ -106,8 +106,8 @@ properties: 
    const: stop



  glink-edge:

    type: object

    description: |

    $ref: qcom,glink-edge.yaml#

    description:

      Qualcomm G-Link subnode which represents communication edge, channels

      and devices related to the ADSP.
@@ -121,21 +121,11 @@ properties: 
          - description: Mailbox for communication between APPS and WPSS



      label:

        description: The names of the state bits used for SMP2P output

        items:

          - const: wpss



      qcom,remote-pid:

        $ref: /schemas/types.yaml#/definitions/uint32

        description: ID of the shared memory used by GLINK for communication with WPSS



    required:

      - interrupts

      - mboxes

      - label

      - qcom,remote-pid



    additionalProperties: false

      apr: false

      fastrpc: false



required:

  - compatible