Commit ae9c4808 authored by Maximilian Weigand's avatar Maximilian Weigand Committed by Lee Jones
Browse files

backlight: lm3630a: Turn off both led strings when display is blank 



Use backlight_is_blank() to determine if the led strings should be turned
off in the update_status() functions of both strings.

Signed-off-by: default avatarMaximilian Weigand <mweigand@mweigand.net>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://lore.kernel.org/r/20230510085239.1253896-1-mweigand2017@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 77036e09

drivers/video/backlight/lm3630a_bl.c

+6 −2
Original line number Diff line number Diff line
@@ -202,7 +202,9 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl) 
	usleep_range(1000, 2000);

	/* minimum brightness is 0x04 */

	ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness);

	if (bl->props.brightness < 0x4)



	if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))

		/* turn the string off  */

		ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);

	else

		ret |= lm3630a_update(pchip, REG_CTRL,
@@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl) 
	usleep_range(1000, 2000);

	/* minimum brightness is 0x04 */

	ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);

	if (bl->props.brightness < 0x4)



	if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))

		/* turn the string off  */

		ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0);

	else

		ret |= lm3630a_update(pchip, REG_CTRL,