Commit ae8f13f0 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Vinod Koul
Browse files

dmaengine: stm32-mdma: Use struct_size() helper in devm_kzalloc()

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.

Link: https://github.com/KSPP/linux/issues/160


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: default avatarAmelie Delaunay <amelie.delaunay@foss.st.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210929222922.GA357509@embeddedor


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 9558cf4a
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -1566,7 +1566,8 @@ static int stm32_mdma_probe(struct platform_device *pdev)
	if (count < 0)
		count = 0;

	dmadev = devm_kzalloc(&pdev->dev, sizeof(*dmadev) + sizeof(u32) * count,
	dmadev = devm_kzalloc(&pdev->dev,
			      struct_size(dmadev, ahb_addr_masks, count),
			      GFP_KERNEL);
	if (!dmadev)
		return -ENOMEM;