Commit ae7d925b authored by Joseph Hwang's avatar Joseph Hwang Committed by Marcel Holtmann
Browse files

Bluetooth: Support the quality report events 



This patch allows a user space process to enable/disable the quality
report events dynamically through the set experimental feature mgmt
interface.

Since the quality report feature needs to invoke the callback function
provided by the driver, i.e., hdev->set_quality_report, a valid
controller index is required.

Reviewed-by: default avatarMiao-chen Chou <mcchou@chromium.org>
Signed-off-by: default avatarJoseph Hwang <josephsih@chromium.org>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 93fb70bc

include/net/bluetooth/hci.h

+1 −0
Original line number Diff line number Diff line
@@ -330,6 +330,7 @@ enum { 
	HCI_ENABLE_LL_PRIVACY,

	HCI_CMD_PENDING,

	HCI_FORCE_NO_MITM,

	HCI_QUALITY_REPORT,



	__HCI_NUM_FLAGS,

};

include/net/bluetooth/hci_core.h

+2 −0
Original line number Diff line number Diff line
@@ -606,6 +606,7 @@ struct hci_dev { 
	int (*set_bdaddr)(struct hci_dev *hdev, const bdaddr_t *bdaddr);

	void (*cmd_timeout)(struct hci_dev *hdev);

	bool (*prevent_wake)(struct hci_dev *hdev);

	int (*set_quality_report)(struct hci_dev *hdev, bool enable);

};



#define HCI_PHY_HANDLE(handle)	(handle & 0xff)
@@ -760,6 +761,7 @@ extern struct mutex hci_cb_list_lock; 
		hci_dev_clear_flag(hdev, HCI_LE_ADV);		\

		hci_dev_clear_flag(hdev, HCI_LL_RPA_RESOLUTION);\

		hci_dev_clear_flag(hdev, HCI_PERIODIC_INQ);	\

		hci_dev_clear_flag(hdev, HCI_QUALITY_REPORT);	\

	} while (0)



/* ----- HCI interface to upper protocols ----- */

net/bluetooth/mgmt.c

+108 −1
Original line number Diff line number Diff line
@@ -3791,6 +3791,12 @@ static const u8 debug_uuid[16] = { 
};

#endif



/* 330859bc-7506-492d-9370-9a6f0614037f */

static const u8 quality_report_uuid[16] = {

	0x7f, 0x03, 0x14, 0x06, 0x6f, 0x9a, 0x70, 0x93,

	0x2d, 0x49, 0x06, 0x75, 0xbc, 0x59, 0x08, 0x33,

};



/* 671b10b5-42c0-4696-9227-eb28d1b049d6 */

static const u8 simult_central_periph_uuid[16] = {

	0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb, 0x27, 0x92,
@@ -3806,7 +3812,7 @@ static const u8 rpa_resolution_uuid[16] = { 
static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev,

				  void *data, u16 data_len)

{

	char buf[62];   /* Enough space for 3 features */

	char buf[82];   /* Enough space for 4 features: 2 + 20 * 4 */

	struct mgmt_rp_read_exp_features_info *rp = (void *)buf;

	u16 idx = 0;

	u32 flags;
@@ -3850,6 +3856,24 @@ static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev, 
		idx++;

	}



	if (hdev) {

		if (hdev->set_quality_report) {

			/* BIT(0): indicating if set_quality_report is

			 * supported by controller.

			 */

			flags = BIT(0);



			/* BIT(1): indicating if the feature is enabled. */

			if (hci_dev_test_flag(hdev, HCI_QUALITY_REPORT))

				flags |= BIT(1);

		} else {

			flags = 0;

		}

		memcpy(rp->features[idx].uuid, quality_report_uuid, 16);

		rp->features[idx].flags = cpu_to_le32(flags);

		idx++;

	}



	rp->feature_count = cpu_to_le16(idx);



	/* After reading the experimental features information, enable
@@ -3892,6 +3916,19 @@ static int exp_debug_feature_changed(bool enabled, struct sock *skip) 
}

#endif



static int exp_quality_report_feature_changed(bool enabled, struct sock *skip)

{

	struct mgmt_ev_exp_feature_changed ev;



	memset(&ev, 0, sizeof(ev));

	memcpy(ev.uuid, quality_report_uuid, 16);

	ev.flags = cpu_to_le32(enabled ? BIT(0) : 0);



	return mgmt_limited_event(MGMT_EV_EXP_FEATURE_CHANGED, NULL,

				  &ev, sizeof(ev),

				  HCI_MGMT_EXP_FEATURE_EVENTS, skip);

}



#define EXP_FEAT(_uuid, _set_func)	\

{					\

	.uuid = _uuid,			\
@@ -4046,6 +4083,75 @@ static int set_rpa_resolution_func(struct sock *sk, struct hci_dev *hdev, 
	return err;

}



static int set_quality_report_func(struct sock *sk, struct hci_dev *hdev,

				   struct mgmt_cp_set_exp_feature *cp,

				   u16 data_len)

{

	struct mgmt_rp_set_exp_feature rp;

	bool val, changed;

	int err;



	/* Command requires to use a valid controller index */

	if (!hdev)

		return mgmt_cmd_status(sk, MGMT_INDEX_NONE,

				       MGMT_OP_SET_EXP_FEATURE,

				       MGMT_STATUS_INVALID_INDEX);



	/* Parameters are limited to a single octet */

	if (data_len != MGMT_SET_EXP_FEATURE_SIZE + 1)

		return mgmt_cmd_status(sk, hdev->id,

				       MGMT_OP_SET_EXP_FEATURE,

				       MGMT_STATUS_INVALID_PARAMS);



	/* Only boolean on/off is supported */

	if (cp->param[0] != 0x00 && cp->param[0] != 0x01)

		return mgmt_cmd_status(sk, hdev->id,

				       MGMT_OP_SET_EXP_FEATURE,

				       MGMT_STATUS_INVALID_PARAMS);



	hci_req_sync_lock(hdev);



	val = !!cp->param[0];

	changed = (val != hci_dev_test_flag(hdev, HCI_QUALITY_REPORT));



	if (!hdev->set_quality_report) {

		err = mgmt_cmd_status(sk, hdev->id,

				      MGMT_OP_SET_EXP_FEATURE,

				      MGMT_STATUS_NOT_SUPPORTED);

		goto unlock_quality_report;

	}



	if (changed) {

		err = hdev->set_quality_report(hdev, val);

		if (err) {

			err = mgmt_cmd_status(sk, hdev->id,

					      MGMT_OP_SET_EXP_FEATURE,

					      MGMT_STATUS_FAILED);

			goto unlock_quality_report;

		}

		if (val)

			hci_dev_set_flag(hdev, HCI_QUALITY_REPORT);

		else

			hci_dev_clear_flag(hdev, HCI_QUALITY_REPORT);

	}



	bt_dev_dbg(hdev, "quality report enable %d changed %d", val, changed);



	memcpy(rp.uuid, quality_report_uuid, 16);

	rp.flags = cpu_to_le32(val ? BIT(0) : 0);

	hci_sock_set_flag(sk, HCI_MGMT_EXP_FEATURE_EVENTS);

	err = mgmt_cmd_complete(sk, hdev->id,

				MGMT_OP_SET_EXP_FEATURE, 0,

				&rp, sizeof(rp));



	if (changed)

		exp_quality_report_feature_changed(val, sk);



unlock_quality_report:

	hci_req_sync_unlock(hdev);

	return err;

}



static const struct mgmt_exp_feature {

	const u8 *uuid;

	int (*set_func)(struct sock *sk, struct hci_dev *hdev,
@@ -4056,6 +4162,7 @@ static const struct mgmt_exp_feature { 
	EXP_FEAT(debug_uuid, set_debug_func),

#endif

	EXP_FEAT(rpa_resolution_uuid, set_rpa_resolution_func),

	EXP_FEAT(quality_report_uuid, set_quality_report_func),



	/* end with a null feature */

	EXP_FEAT(NULL, NULL)