Commit ae50e2ab authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda: cs35l41: Check runtime suspend capability at runtime_idle 

The runtime PM core checks with runtime_idle callback whether it can
goes to the runtime suspend or not, and we can put the boost type
check there instead of runtime_suspend and _resume calls.  This will
reduce the unnecessary runtime_suspend() calls.

Fixes: 1873ebd3 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230105093531.16960-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 15a59cb0

sound/pci/hda/cs35l41_hda.c

+11 −1
Original line number Diff line number Diff line
@@ -647,6 +647,15 @@ static int cs35l41_system_resume(struct device *dev) 
	return ret;

}



static int cs35l41_runtime_idle(struct device *dev)

{

	struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);



	if (cs35l41->hw_cfg.bst_type == CS35L41_EXT_BOOST_NO_VSPK_SWITCH)

		return -EBUSY; /* suspend not supported yet on this model */

	return 0;

}



static int cs35l41_runtime_suspend(struct device *dev)

{

	struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);
@@ -1536,7 +1545,8 @@ void cs35l41_hda_remove(struct device *dev) 
EXPORT_SYMBOL_NS_GPL(cs35l41_hda_remove, SND_HDA_SCODEC_CS35L41);



const struct dev_pm_ops cs35l41_hda_pm_ops = {

	RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume, NULL)

	RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume,

		       cs35l41_runtime_idle)

	SYSTEM_SLEEP_PM_OPS(cs35l41_system_suspend, cs35l41_system_resume)

};

EXPORT_SYMBOL_NS_GPL(cs35l41_hda_pm_ops, SND_HDA_SCODEC_CS35L41);