Commit ae483c20 authored by Naoya Horiguchi's avatar Naoya Horiguchi Committed by Linus Torvalds
Browse files

mm/memory-failure.c: remove obsolete comment 

With the introduction of mf_mutex, most of memory error handling process
is mutually exclusive, so the in-line comment about subtlety about
double-checking PageHWPoison is no more correct.  So remove it.

Link: https://lkml.kernel.org/r/20220125025601.3054511-1-naoya.horiguchi@linux.dev


Signed-off-by: default avatarNaoya Horiguchi <naoya.horiguchi@nec.com>
Suggested-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Reviewed-by: default avatarYang Shi <shy828301@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 77fe7f13

mm/memory-failure.c

+0 −6
Original line number Diff line number Diff line
@@ -2150,12 +2150,6 @@ static int __soft_offline_page(struct page *page) 
		.gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,

	};



	/*

	 * Check PageHWPoison again inside page lock because PageHWPoison

	 * is set by memory_failure() outside page lock. Note that

	 * memory_failure() also double-checks PageHWPoison inside page lock,

	 * so there's no race between soft_offline_page() and memory_failure().

	 */

	lock_page(page);

	if (!PageHuge(page))

		wait_on_page_writeback(page);