Commit ae41d925 authored by Yang Yingliang's avatar Yang Yingliang Committed by Heiko Stuebner
Browse files

drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write() 



After calling clk_prepare_enable(), clk_disable_unprepare() need
be called when calling regmap_write() failed.

Fixes: 1a0f7ed3 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20210519134928.2696617-1-yangyingliang@huawei.com
parent 046e0db9

drivers/gpu/drm/rockchip/cdn-dp-core.c

+1 −0
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp, 
	ret = regmap_write(dp->grf, reg, val);

	if (ret) {

		DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);

		clk_disable_unprepare(dp->grf_clk);

		return ret;

	}