Commit ae3ed15d authored by Daniel Golle's avatar Daniel Golle Committed by Jakub Kicinski
Browse files

net: ethernet: mtk_eth_soc: fix state in __mtk_foe_entry_clear 



Setting ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear
routine as done by commit 0e80707d ("net: ethernet: mtk_eth_soc:
fix typo in __mtk_foe_entry_clear") breaks flow offloading, at least
on older MTK_NETSYS_V1 SoCs, OpenWrt users have confirmed the bug on
MT7622 and MT7621 systems.
Felix Fietkau suggested to use MTK_FOE_STATE_INVALID instead which
works well on both, MTK_NETSYS_V1 and MTK_NETSYS_V2.

Tested on MT7622 (Linksys E8450) and MT7986 (BananaPi BPI-R3).

Suggested-by: default avatarFelix Fietkau <nbd@nbd.name>
Fixes: 0e80707d ("net: ethernet: mtk_eth_soc: fix typo in __mtk_foe_entry_clear")
Fixes: 33fc42de ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries")
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Link: https://lore.kernel.org/r/YzY+1Yg0FBXcnrtc@makrotopia.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0bafedc5

drivers/net/ethernet/mediatek/mtk_ppe.c

+1 −1
Original line number Diff line number Diff line
@@ -412,7 +412,7 @@ __mtk_foe_entry_clear(struct mtk_ppe *ppe, struct mtk_flow_entry *entry) 
	if (entry->hash != 0xffff) {

		ppe->foe_table[entry->hash].ib1 &= ~MTK_FOE_IB1_STATE;

		ppe->foe_table[entry->hash].ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE,

							      MTK_FOE_STATE_UNBIND);

							      MTK_FOE_STATE_INVALID);

		dma_wmb();

	}

	entry->hash = 0xffff;