Commit ae3c57b5 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: Cache R, RW, and W opens separately 



The nfsd open code has always kept separate read-only, read-write, and
write-only opens as necessary to ensure that when a client closes or
downgrades, we don't retain more access than necessary.

Also, I didn't realize the cache behaved this way when I wrote
94415b06 "nfsd4: a client's own opens needn't prevent delegations".
There I assumed fi_fds[O_WRONLY] and fi_fds[O_RDWR] would always be
distinct.  The violation of that assumption is triggering a
WARN_ON_ONCE() and could also cause the server to give out a delegation
when it shouldn't.

Fixes: 94415b06 ("nfsd4: a client's own opens needn't prevent delegations")
Tested-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 0aa99c4d

fs/nfsd/filecache.c

+1 −1
Original line number Diff line number Diff line
@@ -889,7 +889,7 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags, 


	hlist_for_each_entry_rcu(nf, &nfsd_file_hashtbl[hashval].nfb_head,

				 nf_node, lockdep_is_held(&nfsd_file_hashtbl[hashval].nfb_lock)) {

		if ((need & nf->nf_may) != need)

		if (nf->nf_may != need)

			continue;

		if (nf->nf_inode != inode)

			continue;