Commit ae3c253f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab
Browse files

media: platform: mtk-mdp3: work around unused-variable warning 



When CONFIG_OF is disabled, the 'data' variable is not used at all
because of_match_node() turns into a dummy macro:

drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c: In function 'mdp_comp_sub_create':
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:1038:36: error: unused variable 'data' [-Werror=unused-variable]
 1038 |  const struct mtk_mdp_driver_data *data = mdp->mdp_data;
      |                                    ^~~~

Remove the variable again by moving the pointer dereference into the
of_match_node call.

Fixes: b385b991 ("media: platform: mtk-mdp3: chip config split about subcomponents")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 55e2a6e3

drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c

+1 −2
Original line number Diff line number Diff line
@@ -1035,7 +1035,6 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) 
{

	struct device *dev = &mdp->pdev->dev;

	struct device_node *node, *parent;

	const struct mtk_mdp_driver_data *data = mdp->mdp_data;



	parent = dev->of_node->parent;
@@ -1045,7 +1044,7 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) 
		int id, alias_id;

		struct mdp_comp *comp;



		of_id = of_match_node(data->mdp_sub_comp_dt_ids, node);

		of_id = of_match_node(mdp->mdp_data->mdp_sub_comp_dt_ids, node);

		if (!of_id)

			continue;

		if (!of_device_is_available(node)) {