Commit ae297504 authored by Dan Carpenter's avatar Dan Carpenter Committed by J. Bruce Fields
Browse files

net/sunrpc: fix useless comparison in proc_do_xprt() 



In the original code, the "if (*lenp < 0)" check didn't work because
"*lenp" is unsigned.  Fortunately, the memory_read_from_buffer() call
will never fail in this context so it doesn't affect runtime.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent d435c05a

net/sunrpc/sysctl.c

+4 −3
Original line number Diff line number Diff line
@@ -63,19 +63,20 @@ static int proc_do_xprt(struct ctl_table *table, int write, 
			void *buffer, size_t *lenp, loff_t *ppos)

{

	char tmpbuf[256];

	size_t len;

	ssize_t len;



	if (write || *ppos) {

		*lenp = 0;

		return 0;

	}

	len = svc_print_xprts(tmpbuf, sizeof(tmpbuf));

	*lenp = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);

	len = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);



	if (*lenp < 0) {

	if (len < 0) {

		*lenp = 0;

		return -EINVAL;

	}

	*lenp = len;

	return 0;

}