Commit ae2938c3 authored by Paul Cercueil's avatar Paul Cercueil Committed by Greg Kroah-Hartman
Browse files

usb: musb: Fix NULL check on struct musb_request field 



The 'request' variable is a pointer to the 'request' field of the
struct musb_request 'req' pointer. It only worked until now because
the 'request' field is the first one in the musb_request structure, but
as soon as that changes, the check will be invalid.

Fix it preventively by doing the NULL-check on the 'req' pointer
instead.

Suggested-by: default avatarMaarten ter Huurne <maarten@treewalker.org>
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20210123142502.16980-2-paul@crapouillou.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0eaa1a37

drivers/usb/musb/musb_gadget.c

+1 −1
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ void musb_g_tx(struct musb *musb, u8 epnum) 
		return;

	}



	if (request) {

	if (req) {



		trace_musb_req_tx(req);