Commit ae2619dd authored by Geetha sowjanya's avatar Geetha sowjanya Committed by David S. Miller
Browse files

octeontx2-af: Fix irq free in rvu teardown 



Current devlink code try to free already freed irqs as the
irq_allocate flag is not cleared after free leading to kernel
crash while removing rvu driver. The patch fixes the irq free
sequence and clears the irq_allocate flag on free.

Fixes: 7304ac45 ("octeontx2-af: Add mailbox IRQ and msg handlers")
Signed-off-by: default avatarGeetha sowjanya <gakula@marvell.com>
Signed-off-by: default avatarHariprasad Kelam <hkelam@marvell.com>
Signed-off-by: default avatarSunil Kovvuri Goutham <sgoutham@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 29788787

drivers/net/ethernet/marvell/octeontx2/af/rvu.c

+4 −2
Original line number Diff line number Diff line
@@ -2462,8 +2462,10 @@ static void rvu_unregister_interrupts(struct rvu *rvu) 
		    INTR_MASK(rvu->hw->total_pfs) & ~1ULL);



	for (irq = 0; irq < rvu->num_vec; irq++) {

		if (rvu->irq_allocated[irq])

		if (rvu->irq_allocated[irq]) {

			free_irq(pci_irq_vector(rvu->pdev, irq), rvu);

			rvu->irq_allocated[irq] = false;

		}

	}



	pci_free_irq_vectors(rvu->pdev);
@@ -2975,8 +2977,8 @@ static void rvu_remove(struct pci_dev *pdev) 
	struct rvu *rvu = pci_get_drvdata(pdev);



	rvu_dbg_exit(rvu);

	rvu_unregister_interrupts(rvu);

	rvu_unregister_dl(rvu);

	rvu_unregister_interrupts(rvu);

	rvu_flr_wq_destroy(rvu);

	rvu_cgx_exit(rvu);

	rvu_fwdata_exit(rvu);