Commit ae220766 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: remove the unused mode argument to ->release 



The mode argument to the ->release block_device_operation is never used,
so remove it.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Acked-by: Jack Wang <jinpu.wang@ionos.com>			[rnbd]
Link: https://lore.kernel.org/r/20230608110258.189493-10-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d32e2bf8

arch/um/drivers/ubd_kern.c

+2 −2
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ static DEFINE_MUTEX(ubd_lock); 
static DEFINE_MUTEX(ubd_mutex); /* replaces BKL, might not be needed */



static int ubd_open(struct gendisk *disk, fmode_t mode);

static void ubd_release(struct gendisk *disk, fmode_t mode);

static void ubd_release(struct gendisk *disk);

static int ubd_ioctl(struct block_device *bdev, fmode_t mode,

		     unsigned int cmd, unsigned long arg);

static int ubd_getgeo(struct block_device *bdev, struct hd_geometry *geo);
@@ -1182,7 +1182,7 @@ static int ubd_open(struct gendisk *disk, fmode_t mode) 
	return err;

}



static void ubd_release(struct gendisk *disk, fmode_t mode)

static void ubd_release(struct gendisk *disk)

{

	struct ubd *ubd_dev = disk->private_data;

arch/xtensa/platforms/iss/simdisk.c

+1 −1
Original line number Diff line number Diff line
@@ -130,7 +130,7 @@ static int simdisk_open(struct gendisk *disk, fmode_t mode) 
	return 0;

}



static void simdisk_release(struct gendisk *disk, fmode_t mode)

static void simdisk_release(struct gendisk *disk)

{

	struct simdisk *dev = disk->private_data;

	spin_lock(&dev->lock);

block/bdev.c

+7 −7
Original line number Diff line number Diff line
@@ -670,12 +670,12 @@ static int blkdev_get_whole(struct block_device *bdev, fmode_t mode) 
	return 0;

}



static void blkdev_put_whole(struct block_device *bdev, fmode_t mode)

static void blkdev_put_whole(struct block_device *bdev)

{

	if (atomic_dec_and_test(&bdev->bd_openers))

		blkdev_flush_mapping(bdev);

	if (bdev->bd_disk->fops->release)

		bdev->bd_disk->fops->release(bdev->bd_disk, mode);

		bdev->bd_disk->fops->release(bdev->bd_disk);

}



static int blkdev_get_part(struct block_device *part, fmode_t mode)
@@ -699,11 +699,11 @@ static int blkdev_get_part(struct block_device *part, fmode_t mode) 
	return 0;



out_blkdev_put:

	blkdev_put_whole(bdev_whole(part), mode);

	blkdev_put_whole(bdev_whole(part));

	return ret;

}



static void blkdev_put_part(struct block_device *part, fmode_t mode)

static void blkdev_put_part(struct block_device *part)

{

	struct block_device *whole = bdev_whole(part);
@@ -711,7 +711,7 @@ static void blkdev_put_part(struct block_device *part, fmode_t mode) 
		blkdev_flush_mapping(part);

		whole->bd_disk->open_partitions--;

	}

	blkdev_put_whole(whole, mode);

	blkdev_put_whole(whole);

}



struct block_device *blkdev_get_no_open(dev_t dev)
@@ -903,9 +903,9 @@ void blkdev_put(struct block_device *bdev, fmode_t mode) 
	disk_flush_events(disk, DISK_EVENT_MEDIA_CHANGE);



	if (bdev_is_partition(bdev))

		blkdev_put_part(bdev, mode);

		blkdev_put_part(bdev);

	else

		blkdev_put_whole(bdev, mode);

		blkdev_put_whole(bdev);

	mutex_unlock(&disk->open_mutex);



	module_put(disk->fops->owner);

drivers/block/amiflop.c

+1 −1
Original line number Diff line number Diff line
@@ -1709,7 +1709,7 @@ static int floppy_open(struct gendisk *disk, fmode_t mode) 
	return 0;

}



static void floppy_release(struct gendisk *disk, fmode_t mode)

static void floppy_release(struct gendisk *disk)

{

	struct amiga_floppy_struct *p = disk->private_data;

	int drive = p - unit;

drivers/block/aoe/aoeblk.c

+1 −1
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ aoeblk_open(struct gendisk *disk, fmode_t mode) 
}



static void

aoeblk_release(struct gendisk *disk, fmode_t mode)

aoeblk_release(struct gendisk *disk)

{

	struct aoedev *d = disk->private_data;

	ulong flags;