Commit ae1664f0 authored Apr 13, 2023 by Lars-Peter Clausen Committed by Wolfram Sang Apr 18, 2023

i2c: cadence: cdns_i2c_master_xfer(): Fix runtime PM leak on error path



The cdns_i2c_master_xfer() function gets a runtime PM reference when the
function is entered. This reference is released when the function is
exited. There is currently one error path where the function exits
directly, which leads to a leak of the runtime PM reference.

Make sure that this error path also releases the runtime PM reference.

Fixes: 1a351b10 ("i2c: cadence: Added slave support")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

parent 6a8f57ae

drivers/i2c/busses/i2c-cadence.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -827,8 +827,10 @@ static int cdns_i2c_master_xfer(struct i2c_adapter adap, struct i2c_msg msgs,
		#if IS_ENABLED(CONFIG_I2C_SLAVE)
		/* Check i2c operating mode and switch if possible */
		if (id->dev_mode == CDNS_I2C_MODE_SLAVE) {
		if (id->slave_state != CDNS_I2C_SLAVE_STATE_IDLE)
		return -EAGAIN;
		if (id->slave_state != CDNS_I2C_SLAVE_STATE_IDLE) {
		ret = -EAGAIN;
		goto out;
		}

		/* Set mode to master */
		cdns_i2c_set_mode(CDNS_I2C_MODE_MASTER, id);