Commit adf60a87 authored by Siddharth Gupta's avatar Siddharth Gupta Committed by Bjorn Andersson
Browse files

remoteproc: core: Add ops to enable custom coredump functionality 



Each remoteproc might have different requirements for coredumps and might
want to choose the type of dumps it wants to collect. This change allows
remoteproc drivers to specify their own custom dump function to be executed
in place of rproc_coredump. If the coredump op is not specified by the
remoteproc driver it will be set to rproc_coredump by default.

Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarSiddharth Gupta <sidgup@codeaurora.org>
Link: https://lore.kernel.org/r/1605819935-10726-2-git-send-email-sidgup@codeaurora.org


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 0a441514

drivers/remoteproc/remoteproc_core.c

+5 −1
Original line number Diff line number Diff line
@@ -1704,7 +1704,7 @@ int rproc_trigger_recovery(struct rproc *rproc) 
		goto unlock_mutex;



	/* generate coredump */

	rproc_coredump(rproc);

	rproc->ops->coredump(rproc);



	/* load firmware */

	ret = request_firmware(&firmware_p, rproc->firmware, dev);
@@ -2189,6 +2189,10 @@ static int rproc_alloc_ops(struct rproc *rproc, const struct rproc_ops *ops) 
	if (!rproc->ops)

		return -ENOMEM;



	/* Default to rproc_coredump if no coredump function is specified */

	if (!rproc->ops->coredump)

		rproc->ops->coredump = rproc_coredump;



	if (rproc->ops->load)

		return 0;

include/linux/remoteproc.h

+2 −0
Original line number Diff line number Diff line
@@ -375,6 +375,7 @@ enum rsc_handling_status { 
 * @get_boot_addr:	get boot address to entry point specified in firmware

 * @panic:	optional callback to react to system panic, core will delay

 *		panic at least the returned number of milliseconds

 * @coredump:	  collect firmware dump after the subsystem is shutdown

 */

struct rproc_ops {

	int (*prepare)(struct rproc *rproc);
@@ -393,6 +394,7 @@ struct rproc_ops { 
	int (*sanity_check)(struct rproc *rproc, const struct firmware *fw);

	u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw);

	unsigned long (*panic)(struct rproc *rproc);

	void (*coredump)(struct rproc *rproc);

};



/**