Commit adcf6eae authored Aug 01, 2023 by Zhu Wang Committed by Andi Shyti Aug 08, 2023

i2c: remove redundant dev_err_probe()



When platform_get_irq() is called, the error message has been printed,
so it need not to call dev_err_probe() to print error.

As the comment of platform_get_irq() says, it returned non-zero value
when it succeeded, and it returned negative value when it failed.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230801134814.247782-1-wangzhu9@huawei.com


Signed-off-by: Andi Shyti <andi.shyti@kernel.org>

parent f5d5bc5f

drivers/i2c/busses/i2c-davinci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -765,7 +765,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)

		irq = platform_get_irq(pdev, 0);
		if (irq < 0)
		return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
		return irq;

		dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
		if (!dev)

drivers/i2c/busses/i2c-microchip-corei2c.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -378,9 +378,8 @@ static int mchp_corei2c_probe(struct platform_device *pdev)
		return PTR_ERR(idev->base);

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0)
		return dev_err_probe(&pdev->dev, -ENXIO,
		"invalid IRQ %d for I2C controller\n", irq);
		if (irq < 0)
		return irq;

		idev->i2c_clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(idev->i2c_clk))