Unverified Commit ad922ca1 authored by Ravulapati Vishnu vardhan rao's avatar Ravulapati Vishnu vardhan rao Committed by Mark Brown
Browse files

ASoC: amd: Rectifying Unbalanced pm_runtime_enable! issue 



When snd_pci_acp3x driver loads we see:

WARNING kernel:snd_pci_acp3x 0000:04:00.5: Unbalanced pm_runtime_enable!
at boot time.
same can be observed in /var/log/messages/.

Modifying pm runtime sequence for fixing unbalanced pm issue.

Signed-off-by: default avatarRavulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Link: https://lore.kernel.org/r/20200630092242.7799-1-Vishnuvardhanrao.Ravulapati@amd.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bc4be656

sound/soc/amd/raven/pci-acp3x.c

+1 −3
Original line number Diff line number Diff line
@@ -232,9 +232,7 @@ static int snd_acp3x_probe(struct pci_dev *pci, 
	}

	pm_runtime_set_autosuspend_delay(&pci->dev, 2000);

	pm_runtime_use_autosuspend(&pci->dev);

	pm_runtime_set_active(&pci->dev);

	pm_runtime_put_noidle(&pci->dev);

	pm_runtime_enable(&pci->dev);

	pm_runtime_allow(&pci->dev);

	return 0;
@@ -303,7 +301,7 @@ static void snd_acp3x_remove(struct pci_dev *pci) 
	ret = acp3x_deinit(adata->acp3x_base);

	if (ret)

		dev_err(&pci->dev, "ACP de-init failed\n");

	pm_runtime_disable(&pci->dev);

	pm_runtime_forbid(&pci->dev);

	pm_runtime_get_noresume(&pci->dev);

	pci_disable_msi(pci);

	pci_release_regions(pci);