Commit ad6c8a42 authored by Kiwoong Kim's avatar Kiwoong Kim Committed by Martin K. Petersen
Browse files

scsi: ufs: Use generic error code in ufshcd_set_dev_pwr_mode() 

The return value of ufshcd_set_dev_pwr_mode() is passed to device PM
core. However, the function currently returns a SCSI result which the PM
core doesn't understand.  This might lead to unexpected behaviors in
userland; a platform reset was observed in Android.

Use a generic error code for SSU failures.

Link: https://lore.kernel.org/r/1642743182-54098-1-git-send-email-kwmad.kim@samsung.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarKiwoong Kim <kwmad.kim@samsung.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 012d98da

drivers/scsi/ufs/ufshcd.c

+6 −3
Original line number Diff line number Diff line
@@ -8613,7 +8613,7 @@ static void ufshcd_hba_exit(struct ufs_hba *hba) 
 * @pwr_mode: device power mode to set

 *

 * Returns 0 if requested power mode is set successfully

 * Returns non-zero if failed to set the requested power mode

 * Returns < 0 if failed to set the requested power mode

 */

static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,

				     enum ufs_dev_pwr_mode pwr_mode)
@@ -8667,8 +8667,11 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba, 
		sdev_printk(KERN_WARNING, sdp,

			    "START_STOP failed for power mode: %d, result %x\n",

			    pwr_mode, ret);

		if (ret > 0 && scsi_sense_valid(&sshdr))

		if (ret > 0) {

			if (scsi_sense_valid(&sshdr))

				scsi_print_sense_hdr(sdp, NULL, &sshdr);

			ret = -EIO;

		}

	}



	if (!ret)