Commit ad32fe88 authored by Ilya Dryomov's avatar Ilya Dryomov
Browse files

libceph: fix auth_signature buffer allocation in secure mode 



auth_signature frame is 68 bytes in plain mode and 96 bytes in
secure mode but we are requesting 68 bytes in both modes.  By luck,
this doesn't actually result in any invalid memory accesses because
the allocation is satisfied out of kmalloc-96 slab and so exactly
96 bytes are allocated, but KASAN rightfully complains.

Fixes: cd1a677c ("libceph, ceph: implement msgr2.1 protocol (crc and secure modes)")
Reported-by: default avatarLuis Henriques <lhenriques@suse.de>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 60267ba3

net/ceph/messenger_v2.c

+2 −1
Original line number Diff line number Diff line
@@ -1333,7 +1333,8 @@ static int prepare_auth_signature(struct ceph_connection *con) 
	void *buf;

	int ret;



	buf = alloc_conn_buf(con, head_onwire_len(SHA256_DIGEST_SIZE, false));

	buf = alloc_conn_buf(con, head_onwire_len(SHA256_DIGEST_SIZE,

						  con_secure(con)));

	if (!buf)

		return -ENOMEM;