Commit ad32ab96 authored by Juergen Gross's avatar Juergen Gross Committed by Thomas Gleixner
Browse files

irqdomain: Add missing NULL pointer check in irq_domain_create_hierarchy() 



The recent switch to per-domain locking caused a NULL dereference in
irq_domain_create_hierarchy(), as Xen code is calling
msi_create_irq_domain() with a NULL parent pointer.

Fix that by testing parent to be set before dereferencing it. For a
non-existing parent the irqdomain's root will stay to point to
itself.

Fixes: 9dbb8e34 ("irqdomain: Switch to per-domain locking")
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230223083800.31347-1-jgross@suse.com
parent 5931e4eb

kernel/irq/irqdomain.c

+2 −1
Original line number Diff line number Diff line
@@ -1172,6 +1172,7 @@ struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent, 
		domain = __irq_domain_create(fwnode, 0, ~0, 0, ops, host_data);



	if (domain) {

		if (parent)

			domain->root = parent->root;

		domain->parent = parent;

		domain->flags |= flags;