Commit ad1cc6b7 authored by Martin Kaiser's avatar Martin Kaiser Committed by Lorenzo Pieralisi
Browse files

PCI: dwc: Remove IRQ handler and data in one go 

Call irq_set_chained_handler_and_data() to clear the chained handler
and the handler's data under irq_desc->lock.

See also 2cf5a03c ("PCI/keystone: Fix race in installing chained
IRQ handler").

Link: https://lore.kernel.org/r/20210115212435.19940-2-martin@kaiser.cx


Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 3f0ea236

drivers/pci/controller/dwc/pcie-designware-host.c

+2 −4
Original line number Diff line number Diff line
@@ -258,10 +258,8 @@ int dw_pcie_allocate_domains(struct pcie_port *pp) 


static void dw_pcie_free_msi(struct pcie_port *pp)

{

	if (pp->msi_irq) {

		irq_set_chained_handler(pp->msi_irq, NULL);

		irq_set_handler_data(pp->msi_irq, NULL);

	}

	if (pp->msi_irq)

		irq_set_chained_handler_and_data(pp->msi_irq, NULL, NULL);



	irq_domain_remove(pp->msi_domain);

	irq_domain_remove(pp->irq_domain);