Commit ad1c92ff authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

mxser: alloc only needed # of ports 



Many boards have only 2 ports. But we always allocate 8 ports (struct
mxser_port) in each struct mxser_board.

Switch this to an empty/variable sized array ([]) and allocate the
needed number of ports using struct_size helper in ->probe.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-54-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8b6b327

drivers/tty/mxser.c

+3 −2
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ struct mxser_board { 
	enum mxser_must_hwid must_hwid;

	speed_t max_baud;



	struct mxser_port ports[MXSER_PORTS_PER_BOARD];

	struct mxser_port ports[];

};



static DECLARE_BITMAP(mxser_boards, MXSER_BOARDS);
@@ -1923,7 +1923,8 @@ static int mxser_probe(struct pci_dev *pdev, 
		goto err;

	}



	brd = devm_kzalloc(&pdev->dev, sizeof(*brd), GFP_KERNEL);

	brd = devm_kzalloc(&pdev->dev, struct_size(brd, ports, nports),

			GFP_KERNEL);

	if (!brd)

		goto err;