Commit acf50d1a authored by Ruan Jinjie's avatar Ruan Jinjie Committed by David S. Miller
Browse files

net: bcmgenet: Return PTR_ERR() for fixed_phy_register() 



fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The Best practice is to return these
error codes with PTR_ERR().

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Acked-by: default avatarDoug Berger <opendmb@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d6499f0b

drivers/net/ethernet/broadcom/genet/bcmmii.c

+1 −1
Original line number Diff line number Diff line
@@ -619,7 +619,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) 
		phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);

		if (!phydev || IS_ERR(phydev)) {

			dev_err(kdev, "failed to register fixed PHY device\n");

			return -ENODEV;

			return PTR_ERR(phydev);

		}



		/* Make sure we initialize MoCA PHYs with a link down */