Commit acf06a7f authored by Jeff Layton's avatar Jeff Layton Committed by J. Bruce Fields
Browse files

sunrpc: only call test_bit once in svc_xprt_received 



...move the WARN_ON_ONCE inside the following if block since they use
the same condition.

Signed-off-by: default avatarJeff Layton <jlayton@primarydata.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent ef17af2a

net/sunrpc/svc_xprt.c

+4 −2
Original line number Diff line number Diff line
@@ -220,9 +220,11 @@ static struct svc_xprt *__svc_xpo_create(struct svc_xprt_class *xcl, 
 */

static void svc_xprt_received(struct svc_xprt *xprt)

{

	WARN_ON_ONCE(!test_bit(XPT_BUSY, &xprt->xpt_flags));

	if (!test_bit(XPT_BUSY, &xprt->xpt_flags))

	if (!test_bit(XPT_BUSY, &xprt->xpt_flags)) {

		WARN_ONCE(1, "xprt=0x%p already busy!", xprt);

		return;

	}



	/* As soon as we clear busy, the xprt could be closed and

	 * 'put', so we need a reference to call svc_xprt_do_enqueue with:

	 */