Unverified Commit acb43baf authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Mark Brown
Browse files

ASoC: mediatek: mt8188-mt6359: Clean up log levels 



Change some dev_info prints to dev_err() and some to dev_dbg(),
depending on the actual severity of them.

Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarAlexandre Mergnat <amergnat@baylibre.com>
Link: https://lore.kernel.org/r/20230608084727.74403-5-angelogioacchino.delregno@collabora.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4882ef44

sound/soc/mediatek/mt8188/mt8188-mt6359.c

+10 −11
Original line number Diff line number Diff line
@@ -337,9 +337,8 @@ static int mt8188_mt6359_mtkaif_calibration(struct snd_soc_pcm_runtime *rtd) 


			/* handle if never test done */

			if (++counter > 10000) {

				dev_info(afe->dev, "%s(), test fail, cycle_1 %d, cycle_2 %d, monitor 0x%x\n",

					 __func__,

					 cycle_1, cycle_2, monitor);

				dev_err(afe->dev, "%s(), test fail, cycle_1 %d, cycle_2 %d, monitor 0x%x\n",

					__func__, cycle_1, cycle_2, monitor);

				mtkaif_calibration_ok = false;

				break;

			}
@@ -398,7 +397,7 @@ static int mt8188_mt6359_mtkaif_calibration(struct snd_soc_pcm_runtime *rtd) 
	for (i = 0; i < MT8188_MTKAIF_MISO_NUM; i++)

		param->mtkaif_phase_cycle[i] = mtkaif_phase_cycle[i];



	dev_info(afe->dev, "%s(), end, calibration ok %d\n",

	dev_dbg(afe->dev, "%s(), end, calibration ok %d\n",

		__func__, param->mtkaif_calibration_ok);



	return 0;
@@ -486,13 +485,13 @@ static int mt8188_hdmi_codec_init(struct snd_soc_pcm_runtime *rtd) 
					 mt8188_hdmi_jack_pins,

					 ARRAY_SIZE(mt8188_hdmi_jack_pins));

	if (ret) {

		dev_info(rtd->dev, "%s, new jack failed: %d\n", __func__, ret);

		dev_err(rtd->dev, "%s, new jack failed: %d\n", __func__, ret);

		return ret;

	}



	ret = snd_soc_component_set_jack(component, &priv->hdmi_jack, NULL);

	if (ret) {

		dev_info(rtd->dev, "%s, set jack failed on %s (ret=%d)\n",

		dev_err(rtd->dev, "%s, set jack failed on %s (ret=%d)\n",

			__func__, component->name, ret);

		return ret;

	}
@@ -510,13 +509,13 @@ static int mt8188_dptx_codec_init(struct snd_soc_pcm_runtime *rtd) 
					 &priv->dp_jack, mt8188_dp_jack_pins,

					 ARRAY_SIZE(mt8188_dp_jack_pins));

	if (ret) {

		dev_info(rtd->dev, "%s, new jack failed: %d\n", __func__, ret);

		dev_err(rtd->dev, "%s, new jack failed: %d\n", __func__, ret);

		return ret;

	}



	ret = snd_soc_component_set_jack(component, &priv->dp_jack, NULL);

	if (ret) {

		dev_info(rtd->dev, "%s, set jack failed on %s (ret=%d)\n",

		dev_err(rtd->dev, "%s, set jack failed on %s (ret=%d)\n",

			__func__, component->name, ret);

		return ret;

	}