Commit ac87ee0a authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: advansys: Do not set message byte in SCSI status 

The host byte in the SCSI status takes precedence during error recovery, so
there is no point in setting the message byte in addition to a host byte
which is not DID_OK.

Link: https://lore.kernel.org/r/20210427083046.31620-32-hare@suse.de


Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent fdabe57d

drivers/scsi/advansys.c

+0 −2
Original line number Diff line number Diff line
@@ -6728,14 +6728,12 @@ static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep) 
	case QD_ABORTED_BY_HOST:

		ASC_DBG(1, "QD_ABORTED_BY_HOST\n");

		set_status_byte(scp, qdonep->d3.scsi_stat);

		set_msg_byte(scp, qdonep->d3.scsi_msg);

		set_host_byte(scp, DID_ABORT);

		break;



	default:

		ASC_DBG(1, "done_stat 0x%x\n", qdonep->d3.done_stat);

		set_status_byte(scp, qdonep->d3.scsi_stat);

		set_msg_byte(scp, qdonep->d3.scsi_msg);

		set_host_byte(scp, DID_ERROR);

		break;

	}