Commit ac8723e8 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Mathieu Poirier
Browse files

remoteproc/mtk_scp: Remove timeout variable from scp_ipi_send() 



That variable was used twice, but now it's just used once to store
msecs_to_jiffies(wait), fed to wait_event_timeout(): we might as
well remove it for the sake of cleaning up.

This brings no functional changes.

Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230104115341.320951-3-angelogioacchino.delregno@collabora.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent fad151d5

drivers/remoteproc/mtk_scp_ipi.c

+1 −3
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ int scp_ipi_send(struct mtk_scp *scp, u32 id, void *buf, unsigned int len, 
		 unsigned int wait)

{

	struct mtk_share_obj __iomem *send_obj = scp->send_buf;

	unsigned long timeout;

	u32 val;

	int ret;
@@ -197,10 +196,9 @@ int scp_ipi_send(struct mtk_scp *scp, u32 id, void *buf, unsigned int len, 


	if (wait) {

		/* wait for SCP's ACK */

		timeout = msecs_to_jiffies(wait);

		ret = wait_event_timeout(scp->ack_wq,

					 scp->ipi_id_ack[id],

					 timeout);

					 msecs_to_jiffies(wait));

		scp->ipi_id_ack[id] = false;

		if (WARN(!ret, "scp ipi %d ack time out !", id))

			ret = -EIO;