Unverified Commit ac6800e2 authored by Yang Xu's avatar Yang Xu Committed by Christian Brauner (Microsoft)
Browse files

fs: Add missing umask strip in vfs_tmpfile 

All creation paths except for O_TMPFILE handle umask in the vfs directly
if the filesystem doesn't support or enable POSIX ACLs. If the filesystem
does then umask handling is deferred until posix_acl_create().
Because, O_TMPFILE misses umask handling in the vfs it will not honor
umask settings. Fix this by adding the missing umask handling.

Link: https://lore.kernel.org/r/1657779088-2242-2-git-send-email-xuyang2018.jy@fujitsu.com


Fixes: 60545d0d ("[O_TMPFILE] it's still short a few helpers, but infrastructure should be OK now...")
Cc: <stable@vger.kernel.org> # 4.19+
Reported-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-and-Tested-by: default avatarJeff Layton <jlayton@kernel.org>
Acked-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Signed-off-by: default avatarYang Xu <xuyang2018.jy@fujitsu.com>
Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
parent 2b3416ce

fs/namei.c

+2 −0
Original line number Diff line number Diff line
@@ -3565,6 +3565,8 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns, 
	child = d_alloc(dentry, &slash_name);

	if (unlikely(!child))

		goto out_err;

	if (!IS_POSIXACL(dir))

		mode &= ~current_umask();

	error = dir->i_op->tmpfile(mnt_userns, dir, child, mode);

	if (error)

		goto out_err;