Commit ac56a0b4 authored by David Howells's avatar David Howells
Browse files

rxrpc: Fix ICMP/ICMP6 error handling 



Because rxrpc pretends to be a tunnel on top of a UDP/UDP6 socket, allowing
it to siphon off UDP packets early in the handling of received UDP packets
thereby avoiding the packet going through the UDP receive queue, it doesn't
get ICMP packets through the UDP ->sk_error_report() callback.  In fact, it
doesn't appear that there's any usable option for getting hold of ICMP
packets.

Fix this by adding a new UDP encap hook to distribute error messages for
UDP tunnels.  If the hook is set, then the tunnel driver will be able to
see ICMP packets.  The hook provides the offset into the packet of the UDP
header of the original packet that caused the notification.

An alternative would be to call the ->error_handler() hook - but that
requires that the skbuff be cloned (as ip_icmp_error() or ipv6_cmp_error()
do, though isn't really necessary or desirable in rxrpc's case is we want
to parse them there and then, not queue them).

Changes
=======
ver #3)
 - Fixed an uninitialised variable.

ver #2)
 - Fixed some missing CONFIG_AF_RXRPC_IPV6 conditionals.

Fixes: 5271953c ("rxrpc: Use the UDP encap_rcv hook")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent f612466e

include/linux/udp.h

+1 −0
Original line number Diff line number Diff line
@@ -70,6 +70,7 @@ struct udp_sock { 
	 * For encapsulation sockets.

	 */

	int (*encap_rcv)(struct sock *sk, struct sk_buff *skb);

	void (*encap_err_rcv)(struct sock *sk, struct sk_buff *skb, unsigned int udp_offset);

	int (*encap_err_lookup)(struct sock *sk, struct sk_buff *skb);

	void (*encap_destroy)(struct sock *sk);

include/net/udp_tunnel.h

+4 −0
Original line number Diff line number Diff line
@@ -67,6 +67,9 @@ static inline int udp_sock_create(struct net *net, 
typedef int (*udp_tunnel_encap_rcv_t)(struct sock *sk, struct sk_buff *skb);

typedef int (*udp_tunnel_encap_err_lookup_t)(struct sock *sk,

					     struct sk_buff *skb);

typedef void (*udp_tunnel_encap_err_rcv_t)(struct sock *sk,

					   struct sk_buff *skb,

					   unsigned int udp_offset);

typedef void (*udp_tunnel_encap_destroy_t)(struct sock *sk);

typedef struct sk_buff *(*udp_tunnel_gro_receive_t)(struct sock *sk,

						    struct list_head *head,
@@ -80,6 +83,7 @@ struct udp_tunnel_sock_cfg { 
	__u8  encap_type;

	udp_tunnel_encap_rcv_t encap_rcv;

	udp_tunnel_encap_err_lookup_t encap_err_lookup;

	udp_tunnel_encap_err_rcv_t encap_err_rcv;

	udp_tunnel_encap_destroy_t encap_destroy;

	udp_tunnel_gro_receive_t gro_receive;

	udp_tunnel_gro_complete_t gro_complete;

net/ipv4/udp.c

+2 −0
Original line number Diff line number Diff line
@@ -783,6 +783,8 @@ int __udp4_lib_err(struct sk_buff *skb, u32 info, struct udp_table *udptable) 
	 */

	if (tunnel) {

		/* ...not for tunnels though: we don't have a sending socket */

		if (udp_sk(sk)->encap_err_rcv)

			udp_sk(sk)->encap_err_rcv(sk, skb, iph->ihl << 2);

		goto out;

	}

	if (!inet->recverr) {

net/ipv4/udp_tunnel_core.c

+1 −0
Original line number Diff line number Diff line
@@ -72,6 +72,7 @@ void setup_udp_tunnel_sock(struct net *net, struct socket *sock, 


	udp_sk(sk)->encap_type = cfg->encap_type;

	udp_sk(sk)->encap_rcv = cfg->encap_rcv;

	udp_sk(sk)->encap_err_rcv = cfg->encap_err_rcv;

	udp_sk(sk)->encap_err_lookup = cfg->encap_err_lookup;

	udp_sk(sk)->encap_destroy = cfg->encap_destroy;

	udp_sk(sk)->gro_receive = cfg->gro_receive;

net/ipv6/udp.c

+4 −1
Original line number Diff line number Diff line
@@ -616,8 +616,11 @@ int __udp6_lib_err(struct sk_buff *skb, struct inet6_skb_parm *opt, 
	}



	/* Tunnels don't have an application socket: don't pass errors back */

	if (tunnel)

	if (tunnel) {

		if (udp_sk(sk)->encap_err_rcv)

			udp_sk(sk)->encap_err_rcv(sk, skb, offset);

		goto out;

	}



	if (!np->recverr) {

		if (!harderr || sk->sk_state != TCP_ESTABLISHED)