Commit ac483eb3 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

raid1: stop using bio_devname 



Use the %pg format specifier to save on stack consuption and code size.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarSong Liu <song@kernel.org>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20220304180105.409765-8-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ee1925bd

drivers/md/raid1.c

+2 −3
Original line number Diff line number Diff line
@@ -2072,15 +2072,14 @@ static int fix_sync_read_error(struct r1bio *r1_bio) 
		} while (!success && d != r1_bio->read_disk);



		if (!success) {

			char b[BDEVNAME_SIZE];

			int abort = 0;

			/* Cannot read from anywhere, this block is lost.

			 * Record a bad block on each device.  If that doesn't

			 * work just disable and interrupt the recovery.

			 * Don't fail devices as that won't really help.

			 */

			pr_crit_ratelimited("md/raid1:%s: %s: unrecoverable I/O read error for block %llu\n",

					    mdname(mddev), bio_devname(bio, b),

			pr_crit_ratelimited("md/raid1:%s: %pg: unrecoverable I/O read error for block %llu\n",

					    mdname(mddev), bio->bi_bdev,

					    (unsigned long long)r1_bio->sector);

			for (d = 0; d < conf->raid_disks * 2; d++) {

				rdev = conf->mirrors[d].rdev;