Commit ac2a3fee authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: bus: Eliminate acpi_bus_get_device() 



Replace the last instance of acpi_bus_get_device(), added recently
by commit 87e59b36 ("spi: Support selection of the index of the
ACPI Spi Resource before alloc"), with acpi_fetch_acpi_dev() and
finally drop acpi_bus_get_device() that has no more users.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarMark Brown <broonie@kernel.org>
parent 31231092

drivers/acpi/scan.c

+0 −13
Original line number Diff line number Diff line
@@ -588,19 +588,6 @@ static struct acpi_device *handle_to_device(acpi_handle handle, 
	return adev;

}



int acpi_bus_get_device(acpi_handle handle, struct acpi_device **device)

{

	if (!device)

		return -EINVAL;



	*device = handle_to_device(handle, NULL);

	if (!*device)

		return -ENODEV;



	return 0;

}

EXPORT_SYMBOL(acpi_bus_get_device);



/**

 * acpi_fetch_acpi_dev - Retrieve ACPI device object.

 * @handle: ACPI handle associated with the requested ACPI device object.

drivers/spi/spi.c

+2 −1
Original line number Diff line number Diff line
@@ -2406,7 +2406,8 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data) 
			} else {

				struct acpi_device *adev;



				if (acpi_bus_get_device(parent_handle, &adev))

				adev = acpi_fetch_acpi_dev(parent_handle);

				if (!adev)

					return -ENODEV;



				ctlr = acpi_spi_find_controller_by_adev(adev);

include/acpi/acpi_bus.h

+0 −1
Original line number Diff line number Diff line
@@ -509,7 +509,6 @@ extern int unregister_acpi_notifier(struct notifier_block *); 
 * External Functions

 */



int acpi_bus_get_device(acpi_handle handle, struct acpi_device **device);

struct acpi_device *acpi_fetch_acpi_dev(acpi_handle handle);

acpi_status acpi_bus_get_status_handle(acpi_handle handle,

				       unsigned long long *sta);