Commit ac1bc5f9 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Damien Le Moal
Browse files

ata: sata_dwc_460ex: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent d6ef90f1

drivers/ata/sata_dwc_460ex.c

+2 −3
Original line number Diff line number Diff line
@@ -1210,7 +1210,7 @@ static int sata_dwc_probe(struct platform_device *ofdev) 
	return err;

}



static int sata_dwc_remove(struct platform_device *ofdev)

static void sata_dwc_remove(struct platform_device *ofdev)

{

	struct device *dev = &ofdev->dev;

	struct ata_host *host = dev_get_drvdata(dev);
@@ -1226,7 +1226,6 @@ static int sata_dwc_remove(struct platform_device *ofdev) 
#endif



	dev_dbg(dev, "done\n");

	return 0;

}



static const struct of_device_id sata_dwc_match[] = {
@@ -1241,7 +1240,7 @@ static struct platform_driver sata_dwc_driver = { 
		.of_match_table = sata_dwc_match,

	},

	.probe = sata_dwc_probe,

	.remove = sata_dwc_remove,

	.remove_new = sata_dwc_remove,

};



module_platform_driver(sata_dwc_driver);