Commit abf48d58 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by David Sterba
Browse files

btrfs: remove unused bio_flags argument to btrfs_submit_metadata_bio 



This argument is unused since commit 953651eb ("btrfs: factor out
helper adding a page to bio") and commit 1b36294a ("btrfs: call
submit_bio_hook directly for metadata pages") reworked the way metadata
bio submission is handled.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 7aab8b32

fs/btrfs/disk-io.c

+1 −1
Original line number Diff line number Diff line
@@ -921,7 +921,7 @@ static bool should_async_write(struct btrfs_fs_info *fs_info, 
}



blk_status_t btrfs_submit_metadata_bio(struct inode *inode, struct bio *bio,

				       int mirror_num, unsigned long bio_flags)

				       int mirror_num)

{

	struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);

	blk_status_t ret;

fs/btrfs/disk-io.h

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ int btrfs_validate_metadata_buffer(struct btrfs_bio *bbio, 
				   struct page *page, u64 start, u64 end,

				   int mirror);

blk_status_t btrfs_submit_metadata_bio(struct inode *inode, struct bio *bio,

				       int mirror_num, unsigned long bio_flags);

				       int mirror_num);

#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS

struct btrfs_root *btrfs_alloc_dummy_root(struct btrfs_fs_info *fs_info);

#endif

fs/btrfs/extent_io.c

+1 −2
Original line number Diff line number Diff line
@@ -190,8 +190,7 @@ static void submit_one_bio(struct bio *bio, int mirror_num, unsigned long bio_fl 
		btrfs_submit_data_bio(tree->private_data, bio, mirror_num,

					    bio_flags);

	else

		btrfs_submit_metadata_bio(tree->private_data, bio,

						mirror_num, bio_flags);

		btrfs_submit_metadata_bio(tree->private_data, bio, mirror_num);

	/*

	 * Above submission hooks will handle the error by ending the bio,

	 * which will do the cleanup properly.  So here we should not return