rtnetlink: return ENODEV when ifname does not exist and group is given
stable inclusion from stable-v5.10.193 commit 7b79dabd639c79aeab473605f884d37f8e1889a0 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I9399M Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7b79dabd639c79aeab473605f884d37f8e1889a0 -------------------------------- [ Upstream commit ef2a7c90 ] When the interface does not exist, and a group is given, the given parameters are being set to all interfaces of the given group. The given IFNAME/ALT_IF_NAME are being ignored in that case. That can be dangerous since a typo (or a deleted interface) can produce weird side effects for caller: Case 1: IFLA_IFNAME=valid_interface IFLA_GROUP=1 MTU=1234 Case 1 will update MTU and group of the given interface "valid_interface". Case 2: IFLA_IFNAME=doesnotexist IFLA_GROUP=1 MTU=1234 Case 2 will update MTU of all interfaces in group 1. IFLA_IFNAME is ignored in this case This behaviour is not consistent and dangerous. In order to fix this issue, we now return ENODEV when the given IFNAME does not exist. Signed-off-by:Florent Fourcot <florent.fourcot@wifirst.fr> Signed-off-by:
Brian Baboch <brian.baboch@wifirst.fr> Reviewed-by:
Jakub Kicinski <kuba@kernel.org> Signed-off-by:
Paolo Abeni <pabeni@redhat.com> Stable-dep-of: 30188bd7 ("rtnetlink: Reject negative ifindexes in RTM_NEWLINK") Signed-off-by:
Sasha Levin <sashal@kernel.org> Signed-off-by:
sanglipeng <sanglipeng1@jd.com>
Loading
Please sign in to comment