Commit abec6561 authored by Lv Yunlong's avatar Lv Yunlong Committed by Christoph Hellwig
Browse files

nvme-rdma: Fix a use after free in nvmet_rdma_write_data_done 



In nvmet_rdma_write_data_done, rsp is recoverd by wc->wr_cqe and freed by
nvmet_rdma_release_rsp(). But after that, pr_info() used the freed
chunk's member object and could leak the freed chunk address with
wc->wr_cqe by computing the offset.

Signed-off-by: default avatarLv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 0ec84df4

drivers/nvme/target/rdma.c

+2 −3
Original line number Diff line number Diff line
@@ -802,9 +802,8 @@ static void nvmet_rdma_write_data_done(struct ib_cq *cq, struct ib_wc *wc) 
		nvmet_req_uninit(&rsp->req);

		nvmet_rdma_release_rsp(rsp);

		if (wc->status != IB_WC_WR_FLUSH_ERR) {

			pr_info("RDMA WRITE for CQE 0x%p failed with status %s (%d).\n",

				wc->wr_cqe, ib_wc_status_msg(wc->status),

				wc->status);

			pr_info("RDMA WRITE for CQE failed with status %s (%d).\n",

				ib_wc_status_msg(wc->status), wc->status);

			nvmet_rdma_error_comp(queue);

		}

		return;